Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(BUX-631): prevent unneeded header sync #220

Merged
merged 11 commits into from
Mar 12, 2024
Merged

feat(BUX-631): prevent unneeded header sync #220

merged 11 commits into from
Mar 12, 2024

Conversation

kuba-4chain
Copy link
Contributor

@kuba-4chain kuba-4chain commented Mar 8, 2024 •
edited
Loading

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@kuba-4chain kuba-4chain requested a review from a team as a code owner March 8, 2024 13:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2024 •
edited
Loading

Manual Tests

💚 Manual testing by @chris-4chain resulted in success.

@chris-4chain
Copy link
Contributor

I will test it 🧪

@chris-4chain chris-4chain added the tested PR was tested by a team member label Mar 11, 2024
@chris-4chain chris-4chain removed the tested PR was tested by a team member label Mar 11, 2024
dorzepowski
dorzepowski requested changes Mar 11, 2024
View reviewed changes
service/chain_service.go Outdated Show resolved Hide resolved
dorzepowski
dorzepowski reviewed Mar 11, 2024
View reviewed changes
transports/p2p/p2psync/manager.go Outdated Show resolved Hide resolved
transports/p2p/p2psync/manager.go Outdated Show resolved Hide resolved
@chris-4chain chris-4chain added the tested PR was tested by a team member label Mar 12, 2024
@kuba-4chain kuba-4chain merged commit 73b072b into master Mar 12, 2024
9 checks passed
@kuba-4chain kuba-4chain deleted the bux-631-unneeded-sync branch March 12, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorzepowski dorzepowski dorzepowski approved these changes

@chris-4chain chris-4chain chris-4chain approved these changes

@wregulski wregulski wregulski approved these changes

@Nazarii-4chain Nazarii-4chain Nazarii-4chain approved these changes

Assignees
No one assigned
Labels
tested PR was tested by a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kuba-4chain @chris-4chain @dorzepowski @wregulski @Nazarii-4chain